From 266e977935e72b5db49fde7ab9e812c0560f5249 Mon Sep 17 00:00:00 2001 From: suhussai Date: Fri, 4 Sep 2015 21:56:28 -0600 Subject: [PATCH 1/2] refactor function in youtube_dl/compat.py --- youtube_dl/compat.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py index ace5bd716..0670c6d99 100644 --- a/youtube_dl/compat.py +++ b/youtube_dl/compat.py @@ -228,10 +228,7 @@ except ImportError: # Python < 3.3 def compat_ord(c): - if type(c) is int: - return c - else: - return ord(c) + return c if type(c) is int else ord(c) if sys.version_info >= (3, 0): From e11a97ce1a09acf32a89c1d59c0c124458d8438c Mon Sep 17 00:00:00 2001 From: suhussai Date: Fri, 4 Sep 2015 21:57:23 -0600 Subject: [PATCH 2/2] use dictionary comprehension in function definition --- youtube_dl/compat.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py index 0670c6d99..04588daf3 100644 --- a/youtube_dl/compat.py +++ b/youtube_dl/compat.py @@ -207,15 +207,10 @@ except ImportError: # Python 2 def compat_parse_qs(qs, keep_blank_values=False, strict_parsing=False, encoding='utf-8', errors='replace'): - parsed_result = {} pairs = _parse_qsl(qs, keep_blank_values, strict_parsing, encoding=encoding, errors=errors) - for name, value in pairs: - if name in parsed_result: - parsed_result[name].append(value) - else: - parsed_result[name] = [value] - return parsed_result + return {name:(parsed_result[name] + [value] if name in parsed_result + else [value]) for name, value in pairs} try: from shlex import quote as shlex_quote