From b31edaf46d4e6b675d57618b5b8203f24ae9b56b Mon Sep 17 00:00:00 2001 From: Wonchul Kang Date: Fri, 8 Nov 2019 17:58:37 +0900 Subject: [PATCH 1/3] Add AC Fan Speed Mode For Dual AC some lg ac model works dual wind power, left and right in my case model name is PAC_910604_WW looks like below link https://www.lge.co.kr/lgekor/product/aircare/air-conditioner/productDetail.do?cateId=3300&prdId=EPRD.336263 --- wideq/ac.py | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/wideq/ac.py b/wideq/ac.py index 257e1e3..dbf65e6 100644 --- a/wideq/ac.py +++ b/wideq/ac.py @@ -73,6 +73,33 @@ class ACFanSpeed(enum.Enum): POWER = '@AC_MAIN_WIND_STRENGTH_POWER_W' AUTO = '@AC_MAIN_WIND_STRENGTH_AUTO_W' NATURE = '@AC_MAIN_WIND_STRENGTH_NATURE_W' + ''' + some lg ac model works dual wind power, left and right + + in my case model name is PAC_910604_WW + + looks like below link + https://www.lge.co.kr/lgekor/product/aircare/air-conditioner/productDetail.do?cateId=3300&prdId=EPRD.336263 + ''' + R_LOW = '@AC_MAIN_WIND_STRENGTH_LOW_RIGHT_W' + R_MID = '@AC_MAIN_WIND_STRENGTH_MID_RIGHT_W' + R_HIGH = '@AC_MAIN_WIND_STRENGTH_HIGH_RIGHT_W' + L_LOW = '@AC_MAIN_WIND_STRENGTH_LOW_LEFT_W' + L_MID = '@AC_MAIN_WIND_STRENGTH_MID_LEFT_W' + L_HIGH = '@AC_MAIN_WIND_STRENGTH_HIGH_LEFT_W' + L_LOWR_LOW = '@AC_MAIN_WIND_STRENGTH_LOW_LEFT_W|AC_MAIN_WIND_STRENGTH_LOW_RIGHT_W' + L_LOWR_MID = '@AC_MAIN_WIND_STRENGTH_LOW_LEFT_W|AC_MAIN_WIND_STRENGTH_MID_RIGHT_W' + L_LOWR_HIGH = '@AC_MAIN_WIND_STRENGTH_LOW_LEFT_W|AC_MAIN_WIND_STRENGTH_HIGH_RIGHT_W' + L_MIDR_LOW = '@AC_MAIN_WIND_STRENGTH_MID_LEFT_W|AC_MAIN_WIND_STRENGTH_LOW_RIGHT_W' + L_MIDR_MID = '@AC_MAIN_WIND_STRENGTH_MID_LEFT_W|AC_MAIN_WIND_STRENGTH_MID_RIGHT_W' + L_MIDR_HIGH = '@AC_MAIN_WIND_STRENGTH_MID_LEFT_W|AC_MAIN_WIND_STRENGTH_HIGH_RIGHT_W' + L_HIGHR_LOW = '@AC_MAIN_WIND_STRENGTH_HIGH_LEFT_W|AC_MAIN_WIND_STRENGTH_LOW_RIGHT_W' + L_HIGHR_MID = '@AC_MAIN_WIND_STRENGTH_HIGH_LEFT_W|AC_MAIN_WIND_STRENGTH_MID_RIGHT_W' + L_HIGHR_HIGH = '@AC_MAIN_WIND_STRENGTH_HIGH_LEFT_W|AC_MAIN_WIND_STRENGTH_HIGH_RIGHT_W' + AUTO_2 = '@AC_MAIN_WIND_STRENGTH_AUTO_LEFT_W|AC_MAIN_WIND_STRENGTH_AUTO_RIGHT_W' + POWER_2 = '@AC_MAIN_WIND_STRENGTH_POWER_LEFT_W|AC_MAIN_WIND_STRENGTH_POWER_RIGHT_W' + LONGPOWER = '@AC_MAIN_WIND_STRENGTH_LONGPOWER_LEFT_W|AC_MAIN_WIND_STRENGTH_LONGPOWER_RIGHT_W' + class ACOp(enum.Enum): From 6ed250a16e2cade0ef3a4d510998141ada0cc259 Mon Sep 17 00:00:00 2001 From: Wonchul Kang Date: Fri, 8 Nov 2019 18:01:48 +0900 Subject: [PATCH 2/3] Fix for Dual fan ac ACOp.ALL_ON is right. if none dual fan ac than ALL_ON AND RIGHT_ON work is fine. but dual fan ac RIGHT_ON works only right fan. --- wideq/ac.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/wideq/ac.py b/wideq/ac.py index dbf65e6..d16e007 100644 --- a/wideq/ac.py +++ b/wideq/ac.py @@ -106,9 +106,9 @@ class ACOp(enum.Enum): """Whether a device is on or off.""" OFF = "@AC_MAIN_OPERATION_OFF_W" - RIGHT_ON = "@AC_MAIN_OPERATION_RIGHT_ON_W" # This one seems to mean "on"? - LEFT_ON = "@AC_MAIN_OPERATION_LEFT_ON_W" - ALL_ON = "@AC_MAIN_OPERATION_ALL_ON_W" + RIGHT_ON = "@AC_MAIN_OPERATION_RIGHT_ON_W" #only on right fan + LEFT_ON = "@AC_MAIN_OPERATION_LEFT_ON_W" #only on left fan + ALL_ON = "@AC_MAIN_OPERATION_ALL_ON_W" #all on class ACDevice(Device): @@ -224,7 +224,7 @@ class ACDevice(Device): """Turn on or off the device (according to a boolean). """ - op = ACOp.RIGHT_ON if is_on else ACOp.OFF + op = ACOp.ALL_ON if is_on else ACOp.OFF op_value = self.model.enum_value('Operation', op.value) self._set_control('Operation', op_value) From 4316dad8e9fc4436c8a5e93452d9e98d75f71318 Mon Sep 17 00:00:00 2001 From: Wonchul Kang Date: Fri, 8 Nov 2019 20:36:19 +0900 Subject: [PATCH 3/3] Remove Useless comment Remove Useless comment --- wideq/ac.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/wideq/ac.py b/wideq/ac.py index d16e007..897cf7e 100644 --- a/wideq/ac.py +++ b/wideq/ac.py @@ -73,14 +73,6 @@ class ACFanSpeed(enum.Enum): POWER = '@AC_MAIN_WIND_STRENGTH_POWER_W' AUTO = '@AC_MAIN_WIND_STRENGTH_AUTO_W' NATURE = '@AC_MAIN_WIND_STRENGTH_NATURE_W' - ''' - some lg ac model works dual wind power, left and right - - in my case model name is PAC_910604_WW - - looks like below link - https://www.lge.co.kr/lgekor/product/aircare/air-conditioner/productDetail.do?cateId=3300&prdId=EPRD.336263 - ''' R_LOW = '@AC_MAIN_WIND_STRENGTH_LOW_RIGHT_W' R_MID = '@AC_MAIN_WIND_STRENGTH_MID_RIGHT_W' R_HIGH = '@AC_MAIN_WIND_STRENGTH_HIGH_RIGHT_W'