From 6ce734cec0646bdff5af28dd71d1a0620d9ab9f8 Mon Sep 17 00:00:00 2001 From: Nicholas Marriott Date: Fri, 26 Jun 2009 22:13:57 +0000 Subject: [PATCH] After logging (if enabled) is switched to file, there is no reason to keep stdin/stdout/stderr active, so dup them to /dev/null. --- server.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/server.c b/server.c index 9c3b584e..87242b02 100644 --- a/server.c +++ b/server.c @@ -131,7 +131,7 @@ server_client_index(struct client *c) int server_start(char *path) { - int pair[2], srv_fd; + int pair[2], srv_fd, null_fd; char *cause; #ifdef HAVE_SETPROCTITLE char rpathbuf[MAXPATHLEN]; @@ -178,6 +178,18 @@ server_start(char *path) } logfile("server"); + /* + * Close stdin/stdout/stderr. Can't let daemon() do this as they are + * needed until now to print configuration file errors. + */ + if ((null_fd = open(_PATH_DEVNULL, O_RDWR)) != -1) { + dup2(null_fd, STDIN_FILENO); + dup2(null_fd, STDOUT_FILENO); + dup2(null_fd, STDERR_FILENO); + if (null_fd > 2) + close(null_fd); + } + log_debug("server started, pid %ld", (long) getpid()); log_debug("socket path %s", socket_path);