From 567741caf57749205d9c190a901430541e5b1fdf Mon Sep 17 00:00:00 2001 From: Nicholas Marriott Date: Sun, 30 Jan 2011 12:09:30 +0000 Subject: [PATCH] Free old argument even if setting to NULL. --- arguments.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arguments.c b/arguments.c index ebd09580..97ffec13 100644 --- a/arguments.c +++ b/arguments.c @@ -183,11 +183,12 @@ args_has(struct args *args, u_char ch) void args_set(struct args *args, u_char ch, const char *value) { - if (value != NULL) { - if (args->values[ch] != NULL) - xfree(args->values[ch]); + if (args->values[ch] != NULL) + xfree(args->values[ch]); + if (value != NULL) args->values[ch] = xstrdup(value); - } + else + args->values[ch] = NULL; bit_set(args->flags, ch); }