From 0b0f8404086fe33e781c204c651a7f2f2db9d6f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20H=C3=BCbner?= Date: Mon, 24 Apr 2017 11:27:05 +0200 Subject: [PATCH] Improve set index and detail view --- .../views/brickset/instructions.html.twig | 2 - .../views/brickset/reviews.html.twig | 5 +- .../{parts.html.twig => inventory.html.twig} | 11 +- .../views/rebrickable/set/models.html.twig | 48 ++++++++ app/Resources/views/set/detail.html.twig | 116 +++++++++--------- app/Resources/views/set/index.html.twig | 78 ++++++++---- app/config/config.yml | 30 ++++- app/config/service/service.yml | 7 -- app/config/service/util.yml | 7 ++ src/AppBundle/Controller/SetController.php | 9 +- .../Form/Filter/Set/SetFilterType.php | 9 ++ 11 files changed, 218 insertions(+), 104 deletions(-) rename app/Resources/views/rebrickable/set/{parts.html.twig => inventory.html.twig} (75%) create mode 100644 app/Resources/views/rebrickable/set/models.html.twig diff --git a/app/Resources/views/brickset/instructions.html.twig b/app/Resources/views/brickset/instructions.html.twig index 5e64733..be0d271 100644 --- a/app/Resources/views/brickset/instructions.html.twig +++ b/app/Resources/views/brickset/instructions.html.twig @@ -1,5 +1,3 @@ -{% import 'macros/utils.html.twig' as utils %} - {% if instructions|length != 0 %}

{{ 'set.instructions.text' | trans }} diff --git a/app/Resources/views/brickset/reviews.html.twig b/app/Resources/views/brickset/reviews.html.twig index 6b6a89d..d50a23f 100644 --- a/app/Resources/views/brickset/reviews.html.twig +++ b/app/Resources/views/brickset/reviews.html.twig @@ -1,5 +1,5 @@

- {% for review in reviews %} + {% for review in reviews|slice(0, 3) %}
Overall rating
- {#Value for money
#} + Value for money
+ Playability
diff --git a/app/Resources/views/rebrickable/set/parts.html.twig b/app/Resources/views/rebrickable/set/inventory.html.twig similarity index 75% rename from app/Resources/views/rebrickable/set/parts.html.twig rename to app/Resources/views/rebrickable/set/inventory.html.twig index 90b6c2a..c2a2750 100644 --- a/app/Resources/views/rebrickable/set/parts.html.twig +++ b/app/Resources/views/rebrickable/set/inventory.html.twig @@ -1,3 +1,7 @@ +{% import 'macros/elements.html.twig' as elements %} + +This set consists of {{ models|length }} unique part models + {% if regularParts|length > 0 %}

Regular parts @@ -11,8 +15,9 @@ {{ inventoryPart.quantity }}
- +
+
{{ inventoryPart.part.number }}
@@ -34,7 +39,7 @@ {{ inventoryPart.quantity }}
- +
{{ inventoryPart.part.number }}
@@ -43,4 +48,4 @@ {% endif %} {% endfor %} -{% endif %} +{% endif %} \ No newline at end of file diff --git a/app/Resources/views/rebrickable/set/models.html.twig b/app/Resources/views/rebrickable/set/models.html.twig new file mode 100644 index 0000000..e8eb979 --- /dev/null +++ b/app/Resources/views/rebrickable/set/models.html.twig @@ -0,0 +1,48 @@ +{% extends 'base.html.twig' %} + +{% block content %} + {% set count = 0 %} + +
+ {% for model in models %} +
+ + {% for color in model['colors'] %} + {% set count = count + color['quantity'] %} +
{{ color['quantity'] }} {{ color['color'].name }}
+ {% endfor %} +
+ {% endfor %} +
+ + +
+ {% for model in spareModels %} +
+ + {% for color in model['colors'] %} + {% set count = count + color['quantity'] %} +
{{ color['quantity'] }} {{ color['color'].name }}
+ {% endfor %} +
+ {% endfor %} +
+ +

{{ set.partCount }}

+

{{ count }} models

+ +{% endblock %} \ No newline at end of file diff --git a/app/Resources/views/set/detail.html.twig b/app/Resources/views/set/detail.html.twig index 6b93a16..d00d335 100644 --- a/app/Resources/views/set/detail.html.twig +++ b/app/Resources/views/set/detail.html.twig @@ -2,7 +2,7 @@ {% block title %}{{ rbset ? rbset.number }} {{ rbset ? rbset.name }}{% endblock %} -{% block header %}{{ rbset ? rbset.number }} {{ rbset ? rbset.name }}{% endblock %} +{% block header %}{{ rbset ? rbset.number }} {{ rbset ? rbset.name | escape('html') }}{% endblock %} {% block content %} @@ -10,15 +10,15 @@
{% if brset %} - + {% elseif rbset %} - + {% endif %}
- +
@@ -37,7 +37,9 @@ {% endif %} - + {% if brset %} @@ -53,21 +55,21 @@ {% endif %}
number{{ brset ? brset.legoSetID : rbset ? rbset.number : null}}
parts{{ brset ? brset.pieces : rbset ? rbset.partCount }}parts + {{ rbset ? rbset.partCount }} {{ brset ? '('~brset.pieces~')' }} +
- {% if brset is not null %} -
-
themegroup:
{{ brset.themeGroup }}
-
theme:
{{ brset.theme }}
-
subtheme:
{{ brset.subtheme }}
-
count of parts:
{{ brset.pieces }}
-
minifigs:
{{ brset.minifigs }}
-
- {% endif %} + {#{% if brset is not null %}#} + {#
#} + {#
themegroup:
{{ brset.themeGroup }}
#} + {#
theme:
{{ brset.theme }}
#} + {#
subtheme:
{{ brset.subtheme }}
#} + {#
count of parts:
{{ brset.pieces }}
#} + {#
minifigs:
{{ brset.minifigs }}
#} + {#
#} + {#{% endif %}#}
-
-